Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GetConversationsParameters.ExcludeArchived optional #791

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Make GetConversationsParameters.ExcludeArchived optional #791

merged 1 commit into from
Sep 29, 2020

Conversation

9bt
Copy link
Contributor

@9bt 9bt commented Sep 2, 2020 •
edited
Loading

We don't have to set GetConversationsParameters.ExcludeArchived as default,
because exclude_archived in conversations.list is optional from the start.

see also https://api.slack.com/methods/conversations.list

Verification please.

kanata2
kanata2 approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kanata2 kanata2 merged commit 32f3f61 into slack-go:master Sep 29, 2020
@kanata2 kanata2 added this to the v0.7.0 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@9bt @kanata2